Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix #147

Merged
merged 8 commits into from
Jun 8, 2024
Merged

Hotfix #147

merged 8 commits into from
Jun 8, 2024

Conversation

laolarou726
Copy link
Member

@laolarou726 laolarou726 commented May 10, 2024

PR-Codex overview

The focus of this PR is to enhance file entry handling and string comparison methods across multiple components in the project.

Detailed summary

  • Improved handling of file entries in archive processing
  • Enhanced string comparison methods for better accuracy
  • Updated package references for Microsoft.Extensions.ObjectPool and Microsoft.Windows.CsWin32
  • Added a new object _lock for synchronization in DefaultVersionLocator.cs

The following files were skipped due to too many changes: ProjBobcat/ProjBobcat/Platforms/Windows/SystemInfoHelper.Windows.cs, ProjBobcat/ProjBobcat/DefaultComponent/Installer/ForgeInstaller/HighVersionForgeInstaller.cs

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

yueyinqiu
yueyinqiu previously approved these changes May 10, 2024
Copy link
Member

@yueyinqiu yueyinqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没懂这个检查,还有并一下我的 cold fix

@laolarou726 laolarou726 merged commit 4a897de into master Jun 8, 2024
0 of 5 checks passed
Copy link

sonarcloud bot commented Jun 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants