Stream startup and config processing enhancements #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-armstrong
commented
Oct 17, 2019
chris-armstrong
commented
- Wait for stream to become "ACTIVE" before subscribing (helpful with scripts that create a Kinesis stream or use kinesalite)
- Handle different ways of specifying the stream ARN in the event source
AdrieanKhisbe
pushed a commit
that referenced
this pull request
Oct 18, 2019
AdrieanKhisbe
added a commit
that referenced
this pull request
Oct 18, 2019
|
I'm just updating to use avajs instead of jest and get rid of the linting issues |
|
This now has all the linting problems and test framework issues resolved. |
|
Sorry for the late answer @chris-armstrong, Might be interested to split the PR, and try to make pass kinesis retry on it's one (edit, forgot about #89) Cloudformation resolving should be done globally (on all packages), it has been asked and mentionned in many issues/pr (ex #103, #74...) |
|
@chris-armstrong retry mecanism is live since #140 and it's fix in #148. so that just leaves the Cloudformation resolving part to be implemented. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.