Avoid waiting for termination signal upon start-up #137

umairnadeem · 2020-07-06T07:58:23Z

With the following plugin order in serverless.yml, we currently get stuck at the start-up page:

  - serverless-plugin-typescript
  - serverless-offline-kinesis
  - serverless-offline

package.json:

"serverless-offline": "^6.4.0",
"serverless-offline-kinesis": "^4.0.1",
"serverless-plugin-typescript": "^1.1.7"

AdrieanKhisbe · 2020-09-25T16:20:45Z

packages/serverless-offline-kinesis/src/index.js

@@ -75,8 +75,7 @@ class ServerlessOfflineKinesis {

 async _startWithExplicitEnd() {
 await this.start();
- await this.ready();
- this.end();
+ this.ready().then(this.end).catch(() => null);


@umairnadeem do you have some exemple of traces that calling t.end cause?

umairnadeem added 2 commits July 6, 2020 00:54

Avoid waiting for termination signal upon start-up

d3b14c7

Style and lint fix

193ed34

AdrieanKhisbe reviewed Sep 25, 2020

View reviewed changes

AdrieanKhisbe added the serverless-offline-kinesis label Sep 25, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Avoid waiting for termination signal upon start-up #137

Avoid waiting for termination signal upon start-up #137

umairnadeem commented Jul 6, 2020

AdrieanKhisbe Sep 25, 2020

Avoid waiting for termination signal upon start-up #137

Are you sure you want to change the base?

Avoid waiting for termination signal upon start-up #137

Conversation

umairnadeem commented Jul 6, 2020

AdrieanKhisbe Sep 25, 2020

Choose a reason for hiding this comment