Sorting resources in Farmer/Arm for ease of maintenance. #1098
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@isaacabraham the project has gotten pretty big and needs a little more organization. I made a few changes here to reduce the dependencies between IArmResource modules and allow most of them to be alphabetically sorted. What do you think? Any recommendations to make it easier to navigate? |
There was a problem hiding this comment.
Thanks @ninjarobot, looks a fair bit tidier! I have a few small queries (in other threads).
|
|
||
| let fileShares = | ||
| ResourceType("Microsoft.Storage/storageAccounts/fileServices/shares", "2019-06-01") | ||
| let fileShares = ResourceTypes.Storage.fileServices |
There was a problem hiding this comment.
Looks like this is wrong? I don't think it should be the same as the value above.
| let routeTables = ResourceType("Microsoft.Network/routeTables", "2021-01-01") | ||
| let routes = ResourceType("Microsoft.Network/routeTables/routes", "2021-01-01") | ||
|
|
||
| let routeServers = ResourceType("Microsoft.Network/virtualHubs", "2022-11-01") |
There was a problem hiding this comment.
routeServers and virtualHubs sound quite different. What's the reason for the discrepancy?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are as follows:
I have read the contributing guidelines and have completed the following: