Device test runner #1444
Open
Device test runner #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @mattleibow just in case you have something to add (: |
pictos
force-pushed
the
pj/device-test-runner
branch
from
b8415ae
to
f818c9d
Compare
pictos
force-pushed
the
pj/device-test-runner
branch
from
f818c9d
to
5513c8e
Compare
| </ItemGroup> | ||
|
|
||
| <ItemGroup> | ||
| <MauiXaml Update="Tests\UITests\StatusBarTestPage.xaml"> |
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net7.0-android;net7.0-ios;net7.0-maccatalyst</TargetFrameworks> |
There was a problem hiding this comment.
Please use NetVersion instead of net7.0
| public class BehaviorTest | ||
| { | ||
| [Fact] | ||
| public void SuccessfulTest() |
There was a problem hiding this comment.
Let's make it run on your CI first
src/CommunityToolkit.Maui.DeviceTests/CommunityToolkit.Maui.DeviceTests/Tests/BehaviorTest.cs
Show resolved
Hide resolved
VladislavAntonyuk
added
the
hacktoberfest-accepted
* Run tests on Android * fix path * skip warnings * install android sdk * update nuget.config * fix build * use x86-x64 android emulator * use android x64 * ios maccatalyst * fix path * fix ios build * use xcode 14.3.1 * macos-13 * comment android * Run only on Mac
ghost
added
stale
6 tasks
|
@pictos can we merge this PR as it is (with comments fixes)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Device test runner to our repo. It's WiP but it's nice to have some visibility of you all. It's working and if you want you can start to add tests. I added two tests to be a guide for you.
I'll need help of someone who knows yaml in order to create a step on our build to run these tests, I know that Maui does that so we can grab for them (?).
Right now these bits are in preview, and uses a private feed, I added a
nuget.configfile adding the source to the needed packages, I would say it's fine to use it since is the one that .NET MAUI uses and it the team is working in making this stable. Also, using it on our repo is a good way to help them provide early feedback.