cool.html: append WOPISrc parameter to all JS, CSS & SVG loads #9034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeeks
approved these changes
May 11, 2024
Rash419
force-pushed
the
append-external-link
branch
from
90ac2a1
to
d60750c
Compare
@mmeeks I did. Do icons url also needs to be appended with WOPISrc ? |
|
Re: icons - yes, all URLs should have that. |
Rash419
force-pushed
the
append-external-link
branch
from
d60750c
to
f2b28d3
Compare
OK, done |
Rash419
force-pushed
the
append-external-link
branch
from
f2b28d3
to
63d08d3
Compare
Rash419
changed the title
Rash419
force-pushed
the
append-external-link
branch
from
63d08d3
to
24b79a5
Compare
Signed-off-by: Rashesh Padia <[email protected]> Change-Id: I1dd3902403a93914a8ad03b24bed5524a59e5aca
Rash419
force-pushed
the
append-external-link
branch
from
24b79a5
to
233db63
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
- use keyboard shortcut to insert comment Signed-off-by: Rashesh Padia <[email protected]> Change-Id: Ifa3dfd392d3ec6e62b896d34e19b1e9f5854d3c8
Rash419
force-pushed
the
append-external-link
branch
from
0b6ad10
to
f390481
Compare
mmeeks
requested changes
May 18, 2024
|
Also a duplicate pull request it seems; lets abandon this one for now. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I1dd3902403a93914a8ad03b24bed5524a59e5aca