Make headers move on pinch-zoom #9033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minion3665
force-pushed
the
private/skyler/pinch-zoom-headers
branch
from
9073989
to
a1660a3
Compare
|
|
Minion3665
force-pushed
the
private/skyler/pinch-zoom-headers
branch
2 times, most recently
from
44ebbf6
to
d38810c
Compare
While zooming, things like the cursor move along with the zoom. The headers instead stayed fixed until the zoom is complete. This is inconsistent with panning, and worsens your experience when zooming Signed-off-by: Skyler Grey <[email protected]> Change-Id: I100de8f1fd62b831c285c9acab456260dbb77ead
Minion3665
force-pushed
the
private/skyler/pinch-zoom-headers
branch
from
d38810c
to
b508acc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While zooming, things like the cursor move along with the zoom. The headers instead stayed fixed until the zoom is complete. This is inconsistent with panning, and worsens your experience when zooming
Additionally, I refactored the code in the HeaderInfo update() function a little since as so much of it needed to change anyway
Change-Id: I100de8f1fd62b831c285c9acab456260dbb77ead
Summary
TODO
Checklist
make checkmake runand manually verified that everything looks okay