fuzzer, clientsession: fix build #9026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retry. |
retry. |
|
Rebase to be on top of 6bc7e3a. |
Probably went wrong in commit de98583 (wsd: simplify DocumentBroker construction, 2024-04-03). Also init logging to avoid: common/Log.cpp:664:16: runtime error: downcast of address 0x6070000005d0 which does not point to an object of type 'GenericLogger' 0x6070000005d0: note: object is of type 'Poco::Logger' similar to how COOLWSD::innerInitialize() does it. Signed-off-by: Miklos Vajna <[email protected]> Change-Id: Ic16bb2f070e1f0e12204bcc2fc70303d8c1250c8
vmiklos
force-pushed
the
private/vmiklos/master
branch
from
a9fdb94
to
abcfd92
Compare
|
Quoting https://cpci.cbg.collabora.co.uk:8080/job/github_online_master_debug_vs_co-24.04/1419/console:
retry. |
|
@caolanm could you please review this? Thanks. Fix build + make it not instantly crash locally when I try it. |
caolanm
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably went wrong in commit de98583
(wsd: simplify DocumentBroker construction, 2024-04-03).
Also init logging to avoid:
common/Log.cpp:664:16: runtime error: downcast of address 0x6070000005d0 which does not point to an object of type 'GenericLogger'
0x6070000005d0: note: object is of type 'Poco::Logger'
similar to how COOLWSD::innerInitialize() does it.
Signed-off-by: Miklos Vajna [email protected]
Change-Id: Ic16bb2f070e1f0e12204bcc2fc70303d8c1250c8