calc: don't jump to own cursor if not looking #9008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we have cell selected on the bottom of the sheet and we scroll up to watch something else so we don't see the cursor: if other user will add row above - we will jump to our own cursor. It's because it changed the address: like A500 to A5001. Let's don't do that. Solution could be to enter "non following" mode when we scroll outside our own cursor. So we will not jump to our cell if not needed. Then if we click or do any key press - we should cancel that mode and go back to "following own cursor mode". This can be additionaly marked by something on the user list. Signed-off-by: Szymon Kłos <[email protected]> Change-Id: Idde0e4e184fba11597edeb2dc3d426490e46331a
mmeeks
reviewed
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we have cell selected on the bottom of the sheet and we scroll up to watch something else so we don't see the cursor: if other user will add row above - we will jump to our own cursor. It's because it changed the address: like A500 to A5001.
Let's don't do that. Solution could be to enter "non following" mode when we scroll outside our own cursor. So we will not jump to our cell if not needed. Then if we click or do any key press - we should cancel that mode and go back to "following own cursor mode".
This can be additionaly marked by something on the user list.