Fileserver Cache Improvements #9006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmeeks
approved these changes
May 9, 2024
Ashod
force-pushed
the
private/ash/fileserving
branch
5 times, most recently
from
9662d64
to
8c02ba6
Compare
Ashod
force-pushed
the
private/ash/fileserving
branch
3 times, most recently
from
2bd6c4c
to
439f658
Compare
Change-Id: I4ebdbee733922be312a7a5b9b59bcb6c6329a06b Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I31a76e25cff150bcf33d503e6ed9b7fae0e0ed42 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I7b4328785399a2601193d71b5d6f5d1c9f933bfb Signed-off-by: Ashod Nakashian <[email protected]>
This removes explicit file-reading logic with the existing utility function that is more robust and avoid the C++ streaming abstractions altogether. Change-Id: I170b8497a4f9185f1b29e632da27a3520ca0347a Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/fileserving
branch
2 times, most recently
from
0b6e1fc
to
0dc551b
Compare
We now always cache the uncompressed file data even when compressing fails. If no compressed data exists, we return the uncompressed version. Change-Id: I885275dac526f4d47ea74d6badcb609390e7c139 Signed-off-by: Ashod Nakashian <[email protected]>
Change-Id: I25158862746ce6a3e4ee16ff9d661ec96810ce24 Signed-off-by: Ashod Nakashian <[email protected]>
Ashod
force-pushed
the
private/ash/fileserving
branch
from
0dc551b
to
96e74e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reuses file-reading utility, handles errors during compression better (always inserts an uncompressed version of each file and serves it if the compressed version is missing), reduces memory allocation/copying churn, deletes dead code, and adds comments. (Commit log messages have the details.)