Use YouTube source plugin over the deprecated built-in source #6373
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
This PR switches our auto-generated Lavalink
application.yml
file to use the YouTube source plugin over the deprecated built-in source. The proposed implementation does not define this plugin in the Config defaults under theyaml
key and instead dynamically generates it in theServerManager.process_settings()
method. The upsides here are:The downside is that the defaults are no longer placed in a single spot. It is not ideal but there's a need for some redesign to support plugins anyway so I figure this is likely a better solution, at least for now.
Have the changes in this PR been tested?
Yes