#368 show colors in color drop down #369
Conversation
|
Nightly build for this pull request:
|
devo1929
force-pushed
the
color-drop-down
branch
from
51d39f1
to
d832813
Compare
| @@ -17,6 +18,10 @@ public class MultiplayerColor | |||
|
|
|||
| private static List<MultiplayerColor> colorList; | |||
|
|
|||
| private static string randomColorLabel; | |||
|
|
|||
| private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomSide"); | |||
There was a problem hiding this comment.
| private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomSide"); | |
| private static readonly string RandomColorDefaultLabel = "Random".L10N("UI:Main:RandomColor"); |
And also considering making this a readonly property to prevent L10N being called before loading the translation table (although it should works without being a property as long as the class is initialized after L10N initialized but it is not straightforward enough).
There was a problem hiding this comment.
I'm not sure I understand. It is currently readonly. Are you saying it shouldn't be readonly?
There was a problem hiding this comment.
Good catch on the incorrect string.
There was a problem hiding this comment.
I'm not sure I understand. It is currently
readonly. Are you saying it shouldn't be readonly?
No. I mean changing = to =>
There was a problem hiding this comment.
Ahhhhh, I got it. Will do.
devo1929
force-pushed
the
color-drop-down
branch
from
d832813
to
bbe0715
Compare
devo1929
force-pushed
the
color-drop-down
branch
from
bbe0715
to
737d8e2
Compare
|
Seeing the gap between the dropdown border and the color, it might be best if either a custom dropdown control was added that got rid of the gap, or I made the gap customizable in XNAUI. |
Decreased width of color drop down allows for increase of width of player name and side. Color drop down is now the same width as team and start drop downs.
Moved the "Random" label to an INI key.