lan game possible fix #310
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nightly build for this pull request:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a reported issue in the #support channel of Discord where someone's client was crashing while hosting a lan game as soon as another player joined. It happens when the "file hash" message is received from the joining user. When this happens, it attempts to find that player in their host's Player list. It attempts to set the
verifiedproperty totrueon that player. However, the client was not able to find the player in the list for some reason and thus a null pointer exception was being thrown.I provided a temporary new exe to that person and they verified that they were able to play the game with fellow lan members without issue. I don't know if this change will cause any issues though...