Improved UserRequestError message if error is ModbusException. #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stefanpoeter Could you take a look at my PR? |
|
Hi @Zandor300, sorry for the late reply and thank you very much for your contribution. Can you increase the patch number in the package.json. Then I approve it right away. |
|
@stefanpoeter I've changed the version from |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a UserRequestError is thrown because of a Modbus Exception, I added an improved message to the error.
Before it would just print out:
console.error(..)would print out theresponse.body.codeand using that could be seen what the issue is, but when I use the error in conjunction with Sentry error reporting, it won't provide me those values.Now the error message will be something like:
@stefanpoeter Could you take a look?