Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Server Event Listener Overload Mismatch #270

Closed
wants to merge 2 commits into from

Conversation

alexbuczynsky
Copy link
Collaborator

The modbus server does not accept an event
of 'connection' and respond with a net socket.

Fixes #269

The modbus server does not accept an event
of 'connection' and respond with a net socket.
@alexbuczynsky
Copy link
Collaborator Author

@Byorun, let me know if this fixes your issue

@Byorun
Copy link

Byorun commented Aug 27, 2020

@alexbuczynsky on a side note, your lock file is probably outdated
image
removing the lock file let me run npm install

@Byorun
Copy link

Byorun commented Aug 27, 2020

Unfortunately this won't fix the problem.

I checked out the branch, build it and copied the dist to my project but the output is still the same.

And using the original server sample for readCoils

server.on('readCoils', function (request, response, send) {
  /* Implement your own */

  response.body.coils[0] = true
  response.body.coils[1] = false

  send(response)
})

still gives the no overloads match error. I assume this might be a copy and paste error since the server.on() doesn't have a three argument listener, only two

@robot2045
Copy link

Any update on this fix ? @alexbuczynsky @Byorun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server Example seems to be broken
4 participants