Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Beginnings of in-app config #231

Merged
merged 7 commits into from
Sep 22, 2020
Merged

feature: Beginnings of in-app config #231

merged 7 commits into from
Sep 22, 2020

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented Sep 13, 2020

Description

A description of the change and what it does. If relevant, please provide screenshots of what results from the change:

Initial refactorings and additions to support in-app config.

This PR only does a few things, in order to not make giant PRs:

  • Refactor our current options logic to support in-app configs. That is, we can write to a config file with our changes now.
  • The default action when creating a new config file is to leave it blank. (TBD and for now, not sure on this one)
  • Previously, we would set everything in a config file on startup; now we need to read from the config TOML struct whenever.
  • C keybind is now occupied for configs.
  • no_write option to never write to a config file.

Issue

If applicable, what issue does this address?

Part of #159. Closes #241

Type of change

Remove the irrelevant ones:

  • Refactor

Test methodology

If required, please state how this was tested:

Furthermore, please tick which platforms this change was tested on:

  • Windows
  • macOS
  • Linux

Checklist

If relevant, see if the following have been met:

  • Change has been tested to work
  • Areas your change affects have been linted using rustfmt
  • Code has been self-reviewed
  • Code has been tested and no new breakage is introduced unless intended
  • Passes CI tests
  • Documentation has been added/updated if needed (README, help menu, etc.)
  • No merge conflicts arise from the change

Other information

Provide any other relevant information:

@ClementTsang ClementTsang changed the title feature: In-app config menu feature: Beginnings of in-app config Sep 21, 2020
@ClementTsang ClementTsang added the feature Requests for a new feature. label Sep 21, 2020
@ClementTsang ClementTsang added this to In progress in 0.5.0 via automation Sep 21, 2020
@ClementTsang ClementTsang added refactor For refactoring issues. Generally you won't need to use this tag in your report. and removed feature Requests for a new feature. labels Sep 21, 2020
@ClementTsang ClementTsang added feature Requests for a new feature. and removed refactor For refactoring issues. Generally you won't need to use this tag in your report. labels Sep 21, 2020
@ClementTsang ClementTsang marked this pull request as ready for review September 22, 2020 04:40
@ClementTsang ClementTsang merged commit 6db7602 into master Sep 22, 2020
0.5.0 automation moved this from In progress to Done! Sep 22, 2020
@ClementTsang ClementTsang deleted the in_app_config branch September 22, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Requests for a new feature.
Projects
No open projects
0.5.0
  
Done!
Development

Successfully merging this pull request may close these issues.

Refactor existing code to support writing options to a config file
1 participant