Added 'show ip device tracking all' parser for IOS #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreker
changed the title
Taarini
approved these changes
Feb 23, 2023
domachad
requested changes
Mar 1, 2023
src/genie/libs/parser/ios/show_ip.py
Outdated
Comment on lines
85
to
88
| if output is None: | ||
| out = self.device.execute(self.cli_command) | ||
| else: | ||
| out = output |
There was a problem hiding this comment.
Suggested change
| if output is None: | |
| out = self.device.execute(self.cli_command) | |
| else: | |
| out = output | |
| if output is None: | |
| output = self.device.execute(self.cli_command) |
src/genie/libs/parser/ios/show_ip.py
Outdated
| p4 = re.compile( | ||
| r"(Total number interfaces enabled:)\s(?P<numb>\d+)") | ||
|
|
||
| for line in out.splitlines(): |
There was a problem hiding this comment.
Suggested change
| for line in out.splitlines(): | |
| for line in output.splitlines(): |
src/genie/libs/parser/ios/show_ip.py
Outdated
Comment on lines
112
to
114
| m1 = p1.match(line) | ||
|
|
||
| if m1: |
There was a problem hiding this comment.
Suggested change
| m1 = p1.match(line) | |
| if m1: | |
| # Global IP Device Tracking for clients = Enabled | |
| m1 = p1.match(line) | |
| if m1: |
| parsed_dict['state'] = m1.group(1) | ||
| continue | ||
|
|
||
| m2 = p2.match(line) |
There was a problem hiding this comment.
Please add examples of strings that would match the other patterns as well
|
@domachad : I implemented all the changes you have mentioned. Thank you for that. |
domachad
approved these changes
Mar 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added 'show ip device tracking all' parser for IOS devices
Motivation and Context
The parser was missing
Impact (If any)
None
Screenshots:
Checklist: