Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSX Drag to clone with command key(metaKey) instead of ctrlKey #907

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GistCode
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

OSX 'ctrl + click' converts it into a right click action on OSX making 'drag to copy' impossible

Closes #

What is the new behavior?

Use CMD key captured as metaKey for OSX
https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

Use OSX Command key captured as 'metaKey' as an alternative control as 'ctrl + click' converts it into a right click action on OSX

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/metaKey
@GistCode GistCode changed the title Update tree-options.model.ts OSX Drag with command key(metaKey) instead of ctrlKey Mar 30, 2021
@GistCode GistCode changed the title OSX Drag with command key(metaKey) instead of ctrlKey OSX Drag to clone with command key(metaKey) instead of ctrlKey Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant