Make VCRMode::Record overwrite existing files
#19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making this changes to align with the documentation: /// Record requests to the local VCR cassette files. Existing files will be overwritten ... and my expectation as a user coming from Ruby's VCR.
The previous commit cleared interactions every time a new interaction was recorded. That meant that only a single interaction could ever be saved. Here we clear interactions once when the mode is set. This'll happen after interactions have been loaded, since `VCRMiddleware` is instantiated using `TryFrom<PathBuf>` which loads the old interactions.
|
Ready for review 👌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this change to align with the documentation:
/// Record requests to the local VCR cassette files. Existing files will be overwritten... and my expectation as a user coming from Ruby's VCR.
Thanks again for
rvcr, it's great!