Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server/plugins): avoid duplicate settings #6357

Merged
merged 1 commit into from
May 17, 2024
Merged

fix(server/plugins): avoid duplicate settings #6357

merged 1 commit into from
May 17, 2024

Conversation

kontrollanten
Copy link
Contributor

@kontrollanten kontrollanten commented Apr 26, 2024 •
edited

Description

Filter settings so that the name property is unique.

Related issues

closes #6327

Has this been tested?

  • 馃憤 yes, I added tests to the test suite
  • 馃挱 no, because this PR is a draft and still needs work
  • 馃檯 no, because this PR does not update server code
  • 馃檵 no, because I need help

@kontrollanten
fix(server/plugins): avoid duplicate settings
c7c8d3b 
Filter settings so that the name property is unique.

closes Chocobozzz#6356
@Chocobozzz
Copy link
Owner

Thanks!

@Chocobozzz Chocobozzz merged commit 1eb8fc2 into Chocobozzz:develop May 17, 2024
14 checks passed
@kontrollanten kontrollanten deleted the fix-6356-multiple-settings branch May 17, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Possibility for plugins to update settings options value
2 participants
@kontrollanten @Chocobozzz