Add IHttpConnectionFactory for non-HttpClient support #6688
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IHttpConnectionFactory
that returnsIHttpConnection
DefaultHttpConnectionFactory
Closes #6647
I started by trying to modify
IHttpClientFactory
, but quickly realized it is deeply entangled with the Microsoft implementation thereof. Instead, I opted to implement a new factory for the higher-orderIHttpConnection
. However, this necessitated changing some dependencies, especially notably I had to addMicrosoft.Extensions.Http
to the StrawberryShake Tools package (assuming we want to colocateDefaultHttpConnectionFactory
withDefaultHttpClientFactory
, that is).Finally, I'm not sure if I've correctly injected the DefaultHttpConnectionFactory into the DI. I would expect that StrawberryShake should automatically provide this feature for clients so that it does not break any existing clients when new code is generated. However, I'm not sure where that's currently being done for
DefaultHttpClientFactory
(I only see it referenced in CommandTools.cs, so I'm not sure how it's being injected by default for clients) @michaelstaib