-
-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suppress compiler warning in auto-generated code #6474
base: main
Are you sure you want to change the base?
Conversation
HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL] |
HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Are_Executed_Serially [FAIL] |
HotChocolate.Subscriptions.RabbitMQ.RabbitMQIntegrationTests.Subscribe_Topic_With_Arguments [FAIL] |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6474 +/- ##
==========================================
- Coverage 63.92% 63.45% -0.47%
==========================================
Files 2324 2324
Lines 114629 114629
==========================================
- Hits 73275 72739 -536
- Misses 41354 41890 +536
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
72c681f
to
e6c32b8
Compare
HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL] |
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.Depth_Analysis_Overrides_Are_Not_Cached [FAIL] |
e6c32b8
to
05187b1
Compare
05187b1
to
1e0ec77
Compare
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorOverlapsTests.Create_Overlaps_Query [FAIL] |
HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL] |
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.TypeNameFieldIsCorrectlyExecutedOnInterfaces [FAIL] |
HotChocolate.Diagnostics.QueryInstrumentationTests.Track_data_loader_events_with_keys [FAIL] |
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL] |
HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL] |
HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL] |
Kudos, SonarCloud Quality Gate passed! |
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL] |
HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL] |
HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL] |
HotChocolate.Execution.Integration.StarWarsCodeFirst.StarWarsCodeFirstTests.GraphQLOrgVariableWithDefaultValueExample [FAIL] |
StrawberryShake.CodeGeneration.Mappers.ClientDescriptorMapperTests.MapClientDescriptor [FAIL] |
HotChocolate.Data.Spatial.Filters.QueryableFilterVisitorDistanceTests.Create_Distance_Expression [FAIL] |
HotChocolate.Data.Neo4J.Filtering.Neo4JBooleanFilterTests.BooleanFilter_SchemaSnapshot [FAIL] |
HotChocolate.Data.Neo4JBooleanSortingTests.BooleanSorting_SchemaSnapshot [FAIL] |
HotChocolate.Data.Neo4JOffsetPagingTests.OffsetPaging_SchemaSnapshot [FAIL] |
StrawberryShake.CodeGeneration.CSharp.Integration.StarWarsIntrospection.StarWarsIntrospectionTest.Execute_StarWarsIntrospection_Test [FAIL] |
HotChocolate.Execution.Integration.Spec.MutationTests.Ensure_Mutations_Child_Fields_Are_Scoped_To_Its_Parent [FAIL] |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
This seems okay. The alternatives would be:
|
Disabling compiler warning CS1591 (missing XML comment) in the generated code.
Closes #5987