Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not prevent thread revalidation #944

Merged
merged 2 commits into from Apr 29, 2024

Conversation

kevinwmerritt
Copy link
Contributor

Ensures returning to a previously created chat will display all the messages.

@kevinwmerritt kevinwmerritt changed the title do not prevent thread revalidation, fixes Chainlit/chainlit#941 do not prevent thread revalidation Apr 27, 2024
@tpatel
Copy link
Collaborator

tpatel commented Apr 29, 2024

Thanks for the issue + PR 🙏

Is there a reason why you've removed revalidateOnFocus: false ? It looks like the problem was already fixed when you've removed revalidateIfStale: false.

@kevinwmerritt
Copy link
Contributor Author

@tpatel there was not a specific reason. I put back revalidateOnFocus: false. Thanks!

Copy link
Collaborator

@tpatel tpatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution ✨
And thanks for the update 👍

@tpatel tpatel merged commit 0c16c3b into Chainlit:main Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants