Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add ssl support using custom key/cert files #933

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dahifi
Copy link
Contributor

@dahifi dahifi commented Apr 23, 2024

Someone on the discord asked for a way to run the app behind https, so I added a run config parameters to accept keyfile and cert paths, and pass them to uvicorn.

I was unable to run commit hooks on this, nor did I test, but putting this here to see if anyone can validate or pick it up from here.

@puppetm4st3r
Copy link

puppetm4st3r commented Apr 27, 2024

@dahifi if I add those changes to my local, I it will work? or is incomplete ? the added parameters must be provided as environment vars or running paremeters in chainlit executable ?

Best regards!

@tpatel
Copy link
Collaborator

tpatel commented Apr 30, 2024

Thanks for your PR, there is a similar one here: #905

Do you have more background as to why folks who want to create a publicly accessible Chainlit instance without having a proxy in front of it?

@puppetm4st3r
Copy link

puppetm4st3r commented Apr 30, 2024

in my case the reverse proxy + chainlit + serving wasm artifacts didnt liked it to iOS devices, so I have solved appliying this PR and removing the nginx reverse proxy for serving the ssl and works fine.... and its a clearer solution for lite infrastructure use cases.

@veeragoni
Copy link

Thanks for your PR, there is a similar one here: #905

Do you have more background as to why folks who want to create a publicly accessible Chainlit instance without having a proxy in front of it?

localhost

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants