New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conan! #445

Draft

kring wants to merge 107 commits into main from conan-take-two

Member

kring commented Feb 23, 2022

This PR does a bunch of things:

Drastically simplifies the CMake setup:
- Extracted all the utility/helper CMake code to tools/cesium.cmake.
- Each library's CMakeLists.txt is now a proper CMake project that can be used standalone.
- The CMake code in each configuration has been drastically simplified. It mostly just calls cesium_library with its name and dependencies. That function takes care of everything else.
- Our CMake still does not depend on Conan at all. Dependencies are found by using find_package.
Eliminates all the git submodules.
Adds a cesium-native.yml file in the root, and a library.yml in each library directory. These files capture information about cesium-native and the libraries that it contains, including third-party dependencies and their versions.
Added tools/automate.py to do various things, like generate Conan recipes for the libraries from the descriptors in library.yml and cesium-native.yml. Strangely enough this is the first Python program I've ever written, so hopefully it's not too terrible. I used Python because Conan is pretty all-in on it, and it was pretty easy to do. See README.md.
Switched from modp_b64 (copied out of Chromium) to base64 (from Conan Center).
Added recipes for the three remaining third-party libraries that are not yet on Conan Center: csprng, picosha2, and s2geometry.
Added VSCode CMake Kits to use toolchain files generated by Conan.
Added instructions for installing dependencies with Conan and building Conan packages.

Fixes #230
Fixes #248

This PR is a draft until there's a rock-solid cesium-unreal PR to go with it.

kring added 30 commits

January 27, 2022 21:40


Move all of CesiumUtility's dependencies to conan.


Conan driven build/package kinda working for CesiumUtility at least.

663f1dc


Working conan create for CesiumUtility.

8dea8fb


Working package creation for CesiumGltf.

20d5bc3


Uses conan workspaces.

ce20792


One top-level build dir, instead of one in each lib dir.


Cleanup.

7ec1f6f


Conan for CesiumGeometry.

8c55d33


Conanize CesiumGeospatial.

f3f792f


Conanize CesiumAsync.

70e129c


Conanize JsonReader and JsonWriter.

31ce701


Don't use conan workspaces.

b53b34b

They're basically unsupported and don't work with any of the "modern"
stuff.

Instead, add a simple python script to install all the things and
generate a workspace.cmake file that includes all the sub-libraries.


Build missing, only install Debug and Release by default.

d03fc8e


Conanize CesiumGltfWriter.

816c2e2


Conanize Cesium3DTilesSelection.

d82f8b7


Conanize Cesium3DTilesReader/Writer.


Conanize CesiumIonClient.

c282047


Get the tests running.

4a1089a


Remove unused files, create build dir if needed.

35b57f2


Better way of managing dependencies, WIP.

93d345c


Generate conanfile.py for libraries.

4f9c587


Move all libraries to the new system.

6ef9a1c


s2geometry via Conan.

e5208a9


Remove s2geometry submodule.

9b525ee


Better location for s2geometry recipe.

08cffd9


Remove most of the submodules.

538147c


Create csprng package, remove submodule.

64722a9


Remove last submodule.

921df11


Linux/GCC compatibility.

b9261fe


Include profile in install.

7f47cc2

kring added 9 commits

March 11, 2022 21:55


Copy generated headers and dependency headers.

7d0ca9e


Merge remote-tracking branch 'origin/main' into conan-take-two


Don't use std::filesystem.

ce5ca33

Because it's not supported in Unreal Engine's version of libc++.


Do a better job finding the cesium-native root in automate.py.

16e4cac


Debug a weird Python problem on Travis.

2f8a8ca


Resolve root directory more correctly.

4840b34


Remove debug print.

4852e2e


Clean up cmake function.

bddb579


Merge remote-tracking branch 'origin/main' into conan-take-two

401c9f7

cesium-concierge commented Apr 1, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

20 similar comments

cesium-concierge commented May 1, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented May 31, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Jun 30, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Jul 30, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Aug 29, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Sep 28, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Oct 28, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Nov 27, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Dec 27, 2022

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Jan 26, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Feb 25, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Mar 27, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Apr 26, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented May 26, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Jun 25, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Jul 25, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Aug 24, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Sep 23, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Oct 23, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

cesium-concierge commented Nov 22, 2023

Thanks again for your contribution @kring!

No one has commented on this pull request in 30 days. Maintainers, can you review, merge or close to keep things tidy?

I'm going to re-bump this in 30 days. If you'd like me to stop, just comment with @cesium-concierge stop. If you want me to start again, just delete the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment