Allow configuring diag font path at build time #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows for better integration with distros that put the system font in a different directory.
oscarwcl
force-pushed
the
configure-font-path
branch
from
9ee50d5
to
66816a6
Compare
nerijus
reviewed
Jan 17, 2024
| @@ -12,6 +12,14 @@ set(CASPARCG_DOWNLOAD_CACHE ${CMAKE_CURRENT_BINARY_DIR}/external CACHE STRING "D | |||
|
|
|||
| option(ENABLE_HTML "Enable HTML module, require CEF" ON) | |||
|
|
|||
| set(DIAG_FONT_PATH "LiberationMono-Regular.ttf" CACHE STRING | |||
| "Path to font that will be used to load diag font at runtime. By default | |||
| this loads the font distribtued with the application from the working | |||
There was a problem hiding this comment.
typo - distribtued, should be distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for better integration with distros that put the system font in a different directory.
As suggested in #1308 (comment).
The equivalent of the old
-DUSE_SYSTEM_DIAG_FONT=ONoption is now-DDIAG_FONT_PATH=/usr/share/fonts/truetype/liberation/LiberationMono-Regular.ttf