Fix table alias generation mismatch in ConditionsExtractor #786
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously in the provided test case, the aliases would have been generated as:
mentions_users
mentions_users_2
mentions_users_2_3
This was causing issues where the join would be aliases as
mentions_users_3
, however the where statement would be querying a column offmentions_users_2_3
when usingaccessible_by
After this change, the aliases are generated as:
mentions_users
mentions_users_2
mentions_users_3
This allows table names to correctly match up and the query to succeed.
Happy to provide a deeper example if needed, however I would need to anonymise the table names