Unset Parent on Conductors' Items.Clear() #637
+76
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
More discussion in #465 and on stackoverflow. |
Not sure why that test is failing, everything is green locally. 🤔 |
ObservableCollection<T> is designed so NotifyCollectionChangedEventArgs.OldItems is not populated when .Clear() is called on the collection. Because of this, Caliburn conductors can't unset the Parent property on all conducted IChild. There are multiple solutions to this issue that have been discussed, but I feel like adding a new CollectionCleared event to BindableCollection is the best compromise considering it doesn't break any existing code and only extends existing ObservableCollection functionality.
adamgauthier
force-pushed
the
parent-unset-on-clear
branch
from
913e6a8
to
d3e33ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ObservableCollection is designed so
NotifyCollectionChangedEventArgs.OldItems is not populated when .Clear()
is called on the collection. Because of this, Caliburn conductors can't
unset the Parent property on all conducted IChild.
There are multiple solutions to this issue that have been discussed, but
I feel like adding a new CollectionCleared event to BindableCollection
is the best compromise considering it doesn't break any existing code
and only extends existing ObservableCollection functionality.
Fixes #465