fix login remember me with google authentication #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochamarcelo
requested changes
Jan 17, 2019
src/Controller/Traits/LoginTrait.php
Outdated
| // for after login event auth | ||
| $hasRememberMe = $this->request->getSession()->read('hasRememberMe'); | ||
| if ($hasRememberMe) { | ||
| $this->request->data(Configure::read('Users.RememberMe.Cookie.name'), $hasRememberMe); |
There was a problem hiding this comment.
Please add a unit test for this
| @@ -288,6 +288,14 @@ public function verify() | |||
|
|
|||
| $user['secret_verified'] = true; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Please fix code style issues https://travis-ci.org/CakeDC/users/jobs/467177140
src/Controller/Traits/LoginTrait.php
Outdated
|
|
||
| // Push the remember me value to post data | ||
| // for after login event auth | ||
| $hasRememberMe = $this->request->getSession()->read('hasRememberMe'); |
There was a problem hiding this comment.
Please use a namespace key like Users.hasRememberMe
src/Controller/Traits/LoginTrait.php
Outdated
| $hasRememberMe = $this->request->getSession()->read('hasRememberMe'); | ||
| if ($hasRememberMe) { | ||
| $this->request->data(Configure::read('Users.RememberMe.Cookie.name'), $hasRememberMe); | ||
| $this->request->getSession()->delete('hasRememberMe'); |
There was a problem hiding this comment.
Please use a namespace key like Users.hasRememberMe
src/Controller/Traits/LoginTrait.php
Outdated
| // store the remember me value from login into session temporarily | ||
| // to pass the value to verify action | ||
| if (Configure::read('Users.RememberMe.active')) { | ||
| $this->request->getSession()->write('hasRememberMe', $this->request->getData(Configure::read('Users.RememberMe.Cookie.name'))); |
There was a problem hiding this comment.
Please add an unit test for this
|
Will do in a month |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed the bug when I'm using google authenticator, the remember me cookie is not working thus the user session will be revoke even if the remember me is checked.
I used session based solution to pass the value without appearing in the url param.
Thanks.