Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to include solution write ups, and to hide them #2396

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

adb014
Copy link

@adb014 adb014 commented Sep 1, 2023

This is an updated version of the pull request #2238 that also includes

  • The possibility to hide solutions individually
  • The possibility to bulk edit the visibilty of the solutions
  • Updated for 3.6.0

ColdHeat stated

I like the general idea behind this but I'm not sure how complete the implementation has to be. It's simple to just have some text but eventually people will want to add in pictures and such. I will circle back on this.

to the previous pull request. Though this code uses the same editor as the challenge description that already includes the possiblity to include images. See

image

For an example (sorry in french) of what I already have. So I'm not sure I understand the issue. Please note that this pull request modifies the javascript, but doesn't include the changes to the ".dev.js" and ".min.js" files. So an npm run build will be needed to actually use this code. I felt it was better to not include the webpacked files to make it easier to read.

@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #2396 (ecaff85) into master (d8f0b9e) will decrease coverage by 0.03%.
The diff coverage is 78.57%.

❗ Current head ecaff85 differs from pull request most recent head 5fa9227. Consider uploading reports for the commit 5fa9227 to get more accurate results

@@            Coverage Diff             @@
##           master    #2396      +/-   ##
==========================================
- Coverage   87.63%   87.61%   -0.03%     
==========================================
  Files         149      149              
  Lines        9125     9153      +28     
==========================================
+ Hits         7997     8019      +22     
- Misses       1128     1134       +6     
Files Changed Coverage Δ
CTFd/plugins/challenges/__init__.py 98.83% <ø> (ø)
CTFd/plugins/dynamic_challenges/__init__.py 100.00% <ø> (ø)
CTFd/models/__init__.py 96.34% <57.14%> (-0.43%) ⬇️
CTFd/utils/config/visibility.py 95.34% <71.42%> (-4.66%) ⬇️
CTFd/api/v1/challenges.py 95.00% <75.00%> (-0.23%) ⬇️
CTFd/admin/challenges.py 77.19% <100.00%> (+1.26%) ⬆️
CTFd/constants/config.py 96.15% <100.00%> (+0.32%) ⬆️
CTFd/schemas/challenges.py 96.00% <100.00%> (+0.16%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ColdHeat
Copy link
Member

ColdHeat commented Sep 6, 2023

Hi there, I am not against this idea but it will take time to find the time to scope out how this should look and merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants