Downbeats: allow weighting of beats per bar #408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optional parameter, implicitly defaults to ones for the array * Clean up the handling of lengths into the constructor, it was getting verbose * Check weights don't sum to zero, to avoid divide-by-zero pain. * Weight the HMM results in log space by normalised weight values, as suggested by @superbock * Add new test to prove that (sufficient, but arbitrary) weighting to 3-time (over 4-time) does indeed return 3-time beats results. This fixes CPJKU#402.
|
Hi @superbock any thoughts on this PR? |
|
Sorry, still had no time to review this yet. At a first glance it looks good! I don't like |
|
Cool, thanks!
Agreed, I tried for ages to think of something better, but nothing came up... 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
DBNDownBeatTrackingProcessor, add an optional weighting array parameter, implicitly defaulting to onesdoes indeed return 3-time beats results.
This fixes #402.