Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom convex border parameterizers for SMP #8180

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

seirios
Copy link

@seirios seirios commented May 3, 2024

Summary of Changes

Add two new border parameterizers for Surface Mesh Parameterization: Convex_border_parameterizer and Parametric_curve_border_parameterizer. These allow using a convex polygon as border, specified as a point set of which the convex hull is computed (if not already strongly convex), or else a parametric convex curve specified as a pair of functions of the arc-length parameter. These are natural extensions of the Square and Circle border parameterizers already available, respectively. User can provide corresponding corners to the vertices of the convex polygon (as is possible with the Square).

Release Management

  • Affected package(s): Surface Mesh Parameterization
  • Issue(s) solved (if any):
  • Feature/Small Feature (if any):
  • Link to compiled documentation (obligatory for small feature)
  • License and copyright ownership: GPLv3+

Remarks

  • These border parameterizers are working, I've tested them with the Discrete and Iterative authalic parameterizers for a couple meshes. Also, both uniform and arc_length parameterizers seem to be working.
  • Convexity check for the parametric curve parameterizer is not implemented. I tried using the strong convexity check on the points generated on the curve, but it failed for an ellipse, which it should not. Suggestions are welcome.
  • I don't know how to handle matters of copyright, so I just put my name into the file headers. Please guide me on how to do this properly.
  • Documentation would have to be updated.
  • Edges are always parameterized in a "normalized" way, as is the case when corners are given to the Square border parameterizer, even if no corners provided. This ensures consistent behavior when explicitly passing the same corners as the automatic corners (which is not the case with the Square).

+ Convex polygon / convex hull of point set
+ Parametric curve (convex)
@lrineau lrineau added the CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL label May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA/CAA The contributor must sign a CLA or a CAA so that the contribution can be merged into CGAL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants