-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 576 #588
base: main
Are you sure you want to change the base?
Feature/issue 576 #588
Conversation
], | ||
"$schema": "https://democert.org/ssvc/SSVC_Computed_v2.02.schema.json", | ||
"decision_tree_url": "https://democert.org/ssvc/CISA-Coordinator-v2.0.3.json", | ||
"decision_tree_url": "https://democert.org/ssvc/CISA-Coordinator-v2.0.3.json", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are removing the CISA-Coordinator.json, should we redo this example to use a schema we are including?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I remember, the file removed was actually a dead symlink.
"Public Well-being Impact": ["Material"], | ||
"Mission & Well-being": ["medium"] | ||
}, | ||
"outcomes": ["Act"], | ||
"decision_tree_url": "https://democert.org/ssvc/CISA-Coordinator-v2.0.3.json" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment about removing CISA tree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comment on the Computed Schema: is there a way for us to have the computed schema directly draw on the Decision_Point.schema.json
or possibly the Decision_Point_Group.schema.json
? I'll elaborate my thinking in a comment on the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh - Computed Schema should tie to a Decision Point Group Schema, so the plan was to hav ea pedigree like version tracking
Decision Points (multiple) => Decision Point Group (Set selected and a combined versioned) => Provisioned Schema (DP's ordered and versioned) => Computed Schema (tied to Provision version )
This may need a short discussion, I can see it is not clear in the Schema docs, it should be more explicit that DP_Group is tied to a Provisioned schema with a specific version.
Following up on this comment and expanding on this comment from #576: It seems like we need the list of chosen items to include more specificity about what decision point they're drawn from. I was thinking something like: {
"decision_points": [
{
"namespace": "ssvc",
"name": "Exploitation",
"version": "1.0.0",
"key": "E",
"values": [ "None" ]
},
{
"namespace": "ssvc",
"name": "Automatable",
"version": "2.0.0",
"key": "A",
"values": [ "Yes" ]
}
]
} Which shares the In the current Computed example we have {
"Exploitation": "active"
},
{
"Automatable": "no"
} which is now underspecified since there can be different versions of Exploitation and Automatable. |
Optionally the full Decision Tree ordered with outcomes (compliant to |
Some more issues to be concerned about
|
Ideas for result format objects
The example |
This is a major change in Schemas to resolve #576 and try to create new schemas that can be processed by third parties efficiently. This requires some changes to vulnrichment project with ADP exports. Our schema has been updated, but there are external dependencies.
cisagov/vulnrichment#40
There is a new option in the schema called
outcome
which is optional and can be used represent the comprehensive outcomes of the current Decision Tree. This can provide outcomes of the full decision tree, just like the outcomes from a decision point, so the next consumer can use this values to restrict outputs from the decision tree.The JavaScript code also has been updated. This requires a bit of thorough review as there may be other dependencies that are impacted by this schema comprehesnive update. Currently there is a version number in the Computed Schema, but that should be managed before parsers are written to read Computed schema when used alongside of ADP or other data providers.
@j--- may need to help coordinate with CISA developers to ensure the new schema is adopted by CISA developers.