Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sveltosis behaviour on inputs #1050

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

simongeau
Copy link

The goal is to make sure inputs and textarea are binded onInput instead of onChange (which is triggered on blur) so that it is more inline with the Svelte rendering

@vercel
Copy link

vercel bot commented Mar 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mitosis-fiddle ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 16, 2023 4:49pm

@samijaber
Copy link
Contributor

@simongeau Thanks for adding this fix!

If you can follow the steps outlined here: https://github.com/BuilderIO/mitosis/blob/main/developer/README.md#developing-for-core--testing

Essentially: add tests that highlight this change, and format your PR to pass the CI checks. Then we can get this merged in 🙏🏽

@nx-cloud
Copy link

nx-cloud bot commented Jun 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f72373. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 4 targets

Sent with 💌 from NxCloud.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants