Fix - user must be of type string #13688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrinr
requested review from
samwho and
mike12345567
and removed request for
a team
| @@ -80,7 +80,7 @@ export async function search( | |||
|
|
|||
| const table = await sdk.tables.getTable(options.tableId) | |||
| options = searchInputMapping(table, options, { | |||
| isSql: !!table.sql || !!env.SQS_SEARCH_ENABLE, | |||
There was a problem hiding this comment.
Why the removal of this?
|
Addresses: #13684 |
mike12345567
approved these changes
May 15, 2024
|
During these changes, we realised that bulk import (used for tests) was not treating the input row with functions like bbprocessor. This was causing some tests to not work as expected |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some old deprecated user columns had some constrains, forcing the data to be strings. With the recent changes, we were storing them as simple arrays, and this is conflicting with its constrains.
Addresses
Launchcontrol
Fixing a bug causing save issues with old deprecated single columns