-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build Security: airgapped caching and golden hash generation #790
base: develop
Are you sure you want to change the base?
Conversation
d4f9d16
to
06851f5
Compare
06851f5
to
8d9824c
Compare
c91ef1c
to
76821a6
Compare
The plugin cache is necessary and sufficient. The dependency cache could not include plugins, so it was insufficient.
76821a6
to
37d13ff
Compare
98a2112
to
3749b4b
Compare
1c88b12
to
de9deb0
Compare
de9deb0
to
c5f4963
Compare
ea39b8b
to
36733a8
Compare
36733a8
to
b028a56
Compare
Yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll let @HEdingfield tackle this one!
9. Run `gradle run --offline` to launch RCTab | ||
10. Run `gradle jpackage --offline` to generate a jpackage package | ||
|
||
Note: this is not currently available on Silicon-chip Apple Devices. Only Intel Mac is supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What a time to be alive.
I've edited the wiki with steps on golden hash generation. Can those please also get a review |
Reviewed! Looks good. I made a couple cosmetic updates and added some details clarifying where instructions were Windows-only. |
Closes #756: airgapped cache
Closes #759: hash of trusted build
This pull request does four things:
checksums.csv
, which lists a checksum per dependency. That file has an MD5, a SHA-1, and a SHA-256, because we want to correspond our values to those on maven.org, and we don't know what sort of checksum is uploaded to maven.org (it varies by dependency).After code review, I will: