Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Entropy refactor #6397

Merged
merged 1 commit into from
Jun 9, 2024
Merged

feat: Entropy refactor #6397

merged 1 commit into from
Jun 9, 2024

Conversation

limpbrains
Copy link
Collaborator

@limpbrains limpbrains commented Apr 9, 2024 •
edited

  • convert provideEntropy to typescript
  • allow 12 or 24 words
entropy.webm

closes #6344

@limpbrains limpbrains force-pushed the entropy-ts branch 2 times, most recently from 338f588 to 6a96e97 Compare April 16, 2024 22:40
@limpbrains limpbrains force-pushed the entropy-ts branch 2 times, most recently from de29d6b to d47e86d Compare April 27, 2024 16:10
@limpbrains limpbrains force-pushed the entropy-ts branch 2 times, most recently from acec17c to dd5c1a3 Compare June 1, 2024 12:53
@limpbrains limpbrains changed the title fix: rewrite entropy screen in TS feat: Entropy refactor Jun 1, 2024
@limpbrains limpbrains marked this pull request as ready for review June 1, 2024 13:34
marcosrdz
marcosrdz requested changes Jun 1, 2024
View reviewed changes
Copy link
Member

@marcosrdz marcosrdz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Rename file to ProvideEntropy.tsx to follow React component standards

@GladosBlueWallet
Copy link
Collaborator

♫ This was a triumph. I'm making a note here: HUGE SUCCESS ♫

[android in browser] https://appetize.io/app/cjng2wyxqavfb52vti3w7oq6oy?device=pixel4

download apk

@limpbrains limpbrains requested a review from marcosrdz June 2, 2024 19:27
@GladosBlueWallet
Copy link
Collaborator

Wake the fuck up samurai, we have PRs to merge

image

[all PRs for @Overtorment] https://github.com/BlueWallet/BlueWallet/pulls/review-requested/Overtorment

Overtorment
Overtorment approved these changes Jun 9, 2024
View reviewed changes
Copy link
Member

@Overtorment Overtorment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@GladosBlueWallet GladosBlueWallet merged commit 3f52a59 into master Jun 9, 2024
11 of 12 checks passed
@GladosBlueWallet GladosBlueWallet deleted the entropy-ts branch June 9, 2024 21:41
@GladosBlueWallet
Copy link
Collaborator

Unbelievable. You, [subject name here], must be the pride of [subject hometown here]!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Overtorment Overtorment Overtorment approved these changes

@marcosrdz marcosrdz marcosrdz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generate seed with 12 words using entropy
4 participants
@limpbrains @GladosBlueWallet @Overtorment @marcosrdz