Skip to content

Commit

Permalink
feat: add some design consistency improvements
Browse files Browse the repository at this point in the history
  • Loading branch information
Pierniki committed Nov 9, 2023
1 parent 225f2c6 commit c605a64
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 7 deletions.
10 changes: 8 additions & 2 deletions src/components/Navigation/Navigation.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,14 @@ export function Navigation({ navigation }: NavigationProps) {
const categoryUrl = navElement.element?.__typename === "Category" ? "/category" : ""
const url = `/${locale}${categoryUrl}/${navElement?.element?.slug}`
return (
<li key={navElement?.element?.slug} className="rounded-xl p-2 hover:bg-custom-dim">
<Link prefetch={false} href={url} hrefLang={locale} onClick={() => setIsSheetOpen(false)}>
<li key={navElement?.element?.slug}>
<Link
prefetch={false}
href={url}
hrefLang={locale}
onClick={() => setIsSheetOpen(false)}
className="rounded-xl p-2 font-semibold hover:bg-custom-dim"
>
{navElement?.element?.title}
</Link>
</li>
Expand Down
4 changes: 2 additions & 2 deletions src/components/Search/RefinementCombobox.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export function RefinementCombobox(props: RefinementComboboxProps) {
aria-expanded={open}
className="w-[150px] justify-between bg-gray-100 text-gray-400"
>
{`${translations.selectTag}...`}
{translations.selectTag}
<ChevronsUpDown className="ml-2 h-4 w-4 shrink-0 opacity-50" />
</Button>
</PopoverTrigger>
Expand All @@ -50,7 +50,7 @@ export function RefinementCombobox(props: RefinementComboboxProps) {
</div>
<PopoverContent className="ml-6 w-[200px] bg-white p-0">
<Command>
<CommandInput placeholder="Search tags.." />
<CommandInput placeholder={translations.selectTag} />
<CommandEmpty>{translations.noTagsFound}</CommandEmpty>
<CommandGroup value={"value"}>
{items
Expand Down
11 changes: 8 additions & 3 deletions src/components/Search/SearchDialog.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@ function SearchDialogContent() {
return (
<Dialog>
<DialogTrigger asChild>
<Button className="rounded-lg p-4" variant="ghost" aria-label="Open search dialog" name="Search">
<Button
className="rounded-xl p-4 font-semibold hover:bg-custom-dim"
variant="ghost"
aria-label="Open search dialog"
name="Search"
>
<Search className="h-4 w-4" />
</Button>
</DialogTrigger>
Expand All @@ -53,7 +58,7 @@ function SearchDialogContent() {
/>
</NoResultsBoundary>
</DialogContent>
</InstantSearch>{" "}
</InstantSearch>
</Popover>
</Dialog>
)
Expand Down Expand Up @@ -161,7 +166,7 @@ function DebouncedSearchBox() {
type="search"
value={inputValue}
onChange={onChange}
placeholder={`${translations.search}...`}
placeholder={translations.search}
aria-label={translations.search}
/>
)
Expand Down

0 comments on commit c605a64

Please sign in to comment.