Skip to content

Commit

Permalink
Simplify code structure and improve readability
Browse files Browse the repository at this point in the history
This commit seeks to improve readability by removing unnecessary white space and reordering function calls in 'outputmenu.cpp'. In 'outputhandler.cpp', the initialization of data structures such as 'availableOutputs', 'outputsCategorized', and 'categoryStrings' have been simplified. These changes better align with common programming standards.
  • Loading branch information
BitsAndDroids committed Dec 2, 2023
1 parent c8d44b5 commit 0a67f5d
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 5 deletions.
5 changes: 3 additions & 2 deletions handlers/outputhandler.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,9 @@ void OutputHandler::addCategoryString(const QString &category) {
}

void OutputHandler::readOutputs() {
OutputHandler::availableOutputs.clear();
OutputHandler::outputsCategorized.clear();
availableOutputs.clear();
outputsCategorized.clear();
categoryStrings.clear();
QFile file_obj(qApp->applicationDirPath() + "/outputs.json");
file_obj.open(QIODevice::ReadOnly | QIODevice::Text);
QByteArray json_bytes = file_obj.readAll();
Expand Down
4 changes: 1 addition & 3 deletions outputmenu/outputmenu.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,15 +27,13 @@ OutputMenu::OutputMenu(ServiceWorker *pWorker)
} else{
outputMenuLayout->addWidget(setDetaisBuilder.buildOutputDetailsContainer());
}

outputMenuLayout->addWidget(outputTabBuilder.buildOutputTabContainer());

this->findChild<QWidget *>("outputTabWidget")->setVisible(false);
this->setMinimumHeight(500);
this->setStyleSheet("QWidget#outputMenu{background-color:#487f94;}");

QObject::connect(&outputTabBuilder, &OutputTabBuilder::setEdited, this, &OutputMenu::showSetDetails);

connect(&outputTabBuilder, &OutputTabBuilder::setEdited, this, &OutputMenu::showSetDetails);
connect(&setrowBuilder, &SetrowBuilder::showSetDetailsSignal, this, &OutputMenu::showSetDetails);
connect(&setrowBuilder, &SetrowBuilder::editSetSignal, this, &OutputMenu::editSet);
connect(&setrowBuilder, &SetrowBuilder::deleteSetSignal, this, &OutputMenu::deleteSet);
Expand Down

0 comments on commit 0a67f5d

Please sign in to comment.