Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bitcoin Core App Case Study #1084

Merged
merged 3 commits into from May 13, 2024

Conversation

mouxdesign
Copy link
Collaborator

This PR is to add the Bitcoin Core app case study to the guide. It's a very special project to the ecosystem, so far 3 people have reviewed the content of this PR:

  • Christoph
  • Michael
  • Ferreyro
    Still need to work on copy further + images but this makes a first start.

This PR is to add the Bitcoin Core app case study to the guide. It's a very special project to the ecosystem and so far 3 people have reviewed the content of this PR. Still need to work on copy further + images but this makes a first start.
@mouxdesign mouxdesign marked this pull request as draft April 17, 2024 10:40
Copy link

netlify bot commented Apr 17, 2024

Deploy Preview for bitcoin-design-site ready!

Name Link
🔨 Latest commit d1a9a7d
🔍 Latest deploy log https://app.netlify.com/sites/bitcoin-design-site/deploys/6641c6215563d400082720e6
😎 Deploy Preview https://deploy-preview-1084--bitcoin-design-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@GBKS GBKS linked an issue Apr 23, 2024 that may be closed by this pull request
@GBKS GBKS added the Case study Issues that is suited as a case study. label Apr 23, 2024
@GBKS
Copy link
Contributor

GBKS commented Apr 30, 2024

I just updated the PR with the latest content of the Google Doc that we discussed last week in the jam session. Should be good for review now.

🏓Check the preview🏸

@GBKS GBKS marked this pull request as ready for review April 30, 2024 12:46
@rabbitholiness
Copy link
Collaborator

This looks great. I like the balance between the amount of content and the link for further reading 👍. The page is easy to read and give a good overview of the project. At the same time it provides access to a lot more detail for the interested readers.

The only small thing I noticed that the back link at the bottom of the page links to the Payjoin case study instead of to the Wallet Scrutiny one. All other links work as intended.

Copy link
Collaborator Author

@mouxdesign mouxdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This case study looks pretty much ready to fly. Read through it and suggested some minor copy edits.

guide/case-studies/bitcoin-core-app.md Outdated Show resolved Hide resolved
guide/case-studies/bitcoin-core-app.md Outdated Show resolved Hide resolved
guide/case-studies/bitcoin-core-app.md Outdated Show resolved Hide resolved
guide/case-studies/bitcoin-core-app.md Outdated Show resolved Hide resolved
guide/case-studies/bitcoin-core-app.md Show resolved Hide resolved
guide/case-studies/bitcoin-core-app.md Outdated Show resolved Hide resolved
Copy link
Contributor

@GBKS GBKS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@GBKS GBKS merged commit a55190b into BitcoinDesign:master May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Case study Issues that is suited as a case study.
Projects
Development

Successfully merging this pull request may close these issues.

Add a case study about Bitcoin Core App
3 participants