Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameService SPI was removed in Java 9 #2150

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sergiomb2
Copy link
Contributor

and there is no replacement yet.
This commit fix compile of biglybt with Java 9 or Java 11

Also we have some references here: #1017 (comment)

and there is no replacement yet.
This commit fix compile of biglybt with Java 9 or Java 11

Also we have some references here: BiglySoftware#1017 (comment)
@parg
Copy link
Contributor

parg commented Jul 7, 2021

We support Java 8 so this isn't going to be removed until then.

@ferdnyc
Copy link
Contributor

ferdnyc commented Dec 2, 2021

@parg You may not have to forever — the latest Eclipse releases include an SWT that now requires Java 11+.

@ferdnyc
Copy link
Contributor

ferdnyc commented Jul 2, 2022

@sergiomb2 @parg

With #2611 merged, the exclusion of AENameServiceDescriptor when building under JDK 9+ is now completely automatic. Building BiglyBT doesn't force anyone to have to deal with it at all, anymore.

...I think this can probably be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants