(fix): broken ref to submodule 'BiglyBT-plugin-mlDHT'

[javulticat]

Problem

Hi! I noticed that the pipeline for your Github Action pages-build-deployment has been consistently failing for nearly a month, with 8 consecutive failed runs since Nov 25th. Upon investigation, it appears the failures are all related to a change made in 9ffaab7. Specifically, the problem appears to be caused by the change made to the commit that the BiglyBT-plugin-mlDHT submodule references: the submodule's commit ref was changed from BiglySoftware/BiglyBT-plugin-mlDHT@1bf24e3 to BiglySoftware/BiglyBT-plugin-mlDHT@77ffcf1.

Reproduction

The reason that change is causing problems is that the new commit the BiglyBT-plugin-mlDHT submodule is now supposed to reference does not currently appear to exist in the BiglyBT-plugin-mlDHT repository. For example, if you click the link to that commit (BiglySoftware/BiglyBT-plugin-mlDHT@77ffcf1), you'll get a 404. You'll also get a 404 by clicking the current link to the BiglyBT-plugin-mlDHT submodule from this repo:

Solution

Looking at the current commit history on the android branch of BiglyBT-plugin-mlDHT, the only commit more recent than BiglySoftware/BiglyBT-plugin-mlDHT@1bf24e3 that currently exists is BiglySoftware/BiglyBT-plugin-mlDHT@7df6466. Therefore, it can be deduced that if 9ffaab7 intended to update the commit referenced by the BiglyBT-plugin-mlDHT submodule to a more recent commit than BiglySoftware/BiglyBT-plugin-mlDHT@1bf24e3, then BiglySoftware/BiglyBT-plugin-mlDHT@7df6466 is the only commit that would qualify.

Thus, the only change this PR makes is causing BiglySoftware/BiglyBT-plugin-mlDHT@7df6466 (as identified above) to be the commit that will now be referenced by the BiglyBT-plugin-mlDHT submodule (replacing its current problematic reference to the non-extant BiglySoftware/BiglyBT-plugin-mlDHT@77ffcf1).

Verification

It's expected that the intended effect of merging this PR will automatically become fully verifiable within minutes after its merge, as the pages-build-deployment pipeline should get triggered by the merge commit created by merging this PR.

Verification criteria:

Ordered chronologically

• After merge, it is confirmed that the link to the BiglyBT-plugin-mlDHT submodule on Github no longer leads to a 404 page, but instead leads successfully to this page: https://github.com/BiglySoftware/BiglyBT-plugin-mlDHT/tree/7df646696050c490ec1e37c8ce69340b60a8ec74 [Immediately]
• After merge, it is confirmed that the pages-build-deployment pipeline associated with this PR's merge commit ran successfully [Within minutes]
• After merge, it is confirmed that the latest deployment of github-pages changed from having been deployed a month ago by pipeline #148 to having been deployed recently by the pipeline associated with this PR's merge commit (the same pipeline the above criterion refers to) [Within minutes]

fin

Hope this helps!

[Dimezis]

Thank you for this, it really helped me with my fork

[javulticat]

@Dimezis, glad to hear it! Did it resolve the submodule-related Issue you were having (#242)?

Gentle ping for @TuxPaper - not sure if this PR is on your radar. Looks like you're maintaining this repo on your own, so that'd be completely understandable 🙃. As a fellow FLOSS maintainer/developer who has been there - and a long-time user of (and major evangelist for 🗣️) BiglyBT on Android - let me know if there's anything I can do to help!

[Dimezis]

Did it resolve the submodule-related Issue you were having (#242)?

Unfortunately no. It works fine on your branch, and on the latest master with changes from your branch.
But if you sync submodules on top of that, the server no longer starts (or the app can't connect to be precise).

[TuxPaper]

Thanks, I've pushed the android BiglyBT-plugin-mlDHT branch to be up-to-date with the master branch and synced BiglyBT-Android to point to the new reference