Fixes borgs duplicating ammunition with the munition clamp upgrade #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IndusRobot
changed the title
tontyGH
reviewed
May 22, 2024
nsv13/code/modules/munitions/ship_weapons/ballistic_weapons/deck_guns.dm
Show resolved
Hide resolved
Bokkiewokkie
added
Fix
Active Test Merge
Munitions
Bokkiewokkie
approved these changes
May 24, 2024
ss13-beebot
added a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes borg contents not being checked when interacting with multiple powder racks or PDC racks. Normally when
do_afterremoves contents from a human's hands it cancels all other pendingdo_afters. With borg munition clamps their hands do not change, so without refactors their contents will be checked in post by the machine.Why It's Good For The Game
No fun allowed. Fixes #2616
Testing Photographs and Procedure
Screenshots&Videos
NSV.13._.Official._.MRP._.98.Free.Lag._.Spaceship.Combat.Server_.NSV.Dionysias.2024-05-20.14-40-48.mp4
Changelog
馃啈
fix: fix borgs duplicating ammunition in deck turret and PDC
/:cl: