Adding Symfony HttpClient support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b-viguier
force-pushed
the
feature/sf-http-client
branch
from
f99d02a
to
67a709d
Compare
gbouyge
approved these changes
Nov 16, 2019
valentin-claras
approved these changes
Nov 18, 2019
|
Current status: Travis does not support HTTP/2 example, seems related to curl… I'm trying to see if Sf client is able to fallback to HTTP/1 automatically… |
b-viguier
force-pushed
the
feature/sf-http-client
branch
from
f85d641
to
2d42e25
Compare
fragab
approved these changes
Nov 20, 2019
b-viguier
force-pushed
the
feature/sf-http-client
branch
4 times, most recently
from
204e235
to
03c8fdc
Compare
b-viguier
force-pushed
the
feature/sf-http-client
branch
from
03c8fdc
to
16609e5
Compare
|
🎉 I copied logic from SF to Guzzle client 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony released a new HttpClient component, with support of asynchronous requests and Http2 support. This PR add an adapter for this new HttpClient.
The big change is the support of HTTP2, the
examples/03-http-client.phphas been adapted to show the performances gain: up to 4x times faster in Http2 🎉 . Of course, this example is an ideal case, where all requests are made on the same server supporting Http2, but it's promising.Note: Symfony client does not support PSR-7 interfaces natively, then you need to provide some factories (PSR-17)to instantiate PSR-7 responses, https://github.com/Nyholm/http-factory is suggested