Adds step to prepare() when calling PlayQueueItem #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrading Windows SDK version to address version downgrade
7 tasks
|
Yes. Let me fix that. |
Refactors PlayQueueItem(mediaItem) to use PlayQueueItem(index) to reduce duplicated code
|
@janwiebe-jump Updated the code so that PlayQueueItem prepares in both instances. Also refactored to eliminate the duplication in those methods. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading Windows SDK version to address version downgrade
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix.
When starting a queue from PlayQueueItem, the media plays, but when play is subsequently called, it restarts the queue
🆕 What is the new behavior (if this is a feature change)?
Calling pause and play now behave appropriate after starting a queue with PlayQueueItem
💥 Does this PR introduce a breaking change?
No.
🐛 Recommendations for testing
Test using an app the loads a queue then starts any item with PlayQueueItem.
📝 Links to relevant issues/docs
#856
🤔 Checklist before submitting