Feature/pbr materials extensions #1116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 23, 2024 17:32
…, only occured with fullPBR export. Properly setting and exporting material transmission data and extension. Two white space formatting fixes.
|
Thanks @imbrig for your PR! We'll take a look at it in July. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Maya Exporter, several PBR material extensions such as
KHR_materials_transmission,KHR_materials_ior,KHR_materials_sheen&KHR_materials_specularare not hooked up to export material properties from Maya. Also running theFullBPRexport flag would crash the exporter, this option is also disabled in the Maya Babylon export gui.How
First, had to enable and fix the crash with
FullBPRexporting. Then handling the Maya material properties and assigning them to the Babylon Material for export according to the extension parameters forKHR_materials_transmission,KHR_materials_ior,KHR_materials_sheen&KHR_materials_specular. Lastly, code clean up.