Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xrCompatible false per default, canvas made compatible on demand #15027

Merged
merged 1 commit into from May 3, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 24, 2024

This is a breaking change that should never influence any of our users.

We set the canvas to be xrCompatible per default. mainly because there was no downside for the devs, and they could override this. However, this thread has shed some light on a single issue that was found with it - https://forum.babylonjs.com/t/browser-back-forward-cache-is-blocked-when-using-babylon-js-due-to-webxr/49903, namely browser back-forward cache is blocked when using a WebXR-enabled canvas.

This PR sets the flag to false per default and simplifies the mechanism in which a canvas is prepared for XR compatibility.

Please wait with merging this until the community has tested the snapshot, as I only have an emulator for the time being. Of course, it works correctly in both the windows XR emulator and the WebXR web-based emulator

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 24, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 24, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 24, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/15027/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 24, 2024

@deltakosh
Copy link
Contributor

@RaananW : please document it here: https://doc.babylonjs.com/breaking-changes

@RaananW RaananW merged commit 31530f7 into BabylonJS:master May 3, 2024
11 checks passed
@RaananW RaananW deleted the xrompatibleNotDefault branch May 3, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants