Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip internals in declarations #14982

Closed
wants to merge 1 commit into from

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Apr 15, 2024

This will remove @internal functions in the public packages.

The reason for moving the core build to the end is that the core build rebuilds the core package, and if it is built first, other packages depending on core will faill if they use internals.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 15, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 15, 2024

Reviewer - this PR has made changes to one or more package.json files.

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 15, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Apr 15, 2024

Visualization tests for WebGPU (Experimental)
Important - these might fail sporadically. This is an optional test.

https://babylonsnapshots.z22.web.core.windows.net/refs/pull/14982/merge/testResults/webgpuplaywright/index.html

@RaananW RaananW marked this pull request as draft April 15, 2024 11:46
Copy link

This pull request has been marked as stale because it has been inactive for more than 14 days. Please update to "unstale".

@github-actions github-actions bot added the stale label May 14, 2024
@RaananW RaananW closed this May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants