Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: new domain name creation method #4176

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

truboxl
Copy link
Contributor

@truboxl truboxl commented Feb 10, 2021

Fixes #2846

Description of the Change
New domain name will be created based on brand, model, random strings on Android, else fallback to old way if something went awry

Alternate Designs
No idea how to do this using Java / Kotlin
I pick brand over manufacturer, since some phones have brand "Nokia" but manufacturer "HMD Global"

Release Notes
client: new android domain name creation method

@AenBleidd AenBleidd self-assigned this Feb 10, 2021
@AenBleidd AenBleidd self-requested a review February 10, 2021 10:19
@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #4176 (2378fb0) into master (f0a52e1) will increase coverage by 4.13%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master   #4176      +/-   ##
===========================================
+ Coverage      2.86%   6.99%   +4.13%     
- Complexity        0     756     +756     
===========================================
  Files           178     278     +100     
  Lines         27832   35087    +7255     
  Branches          0    1526    +1526     
===========================================
+ Hits            797    2454    +1657     
- Misses        27035   32521    +5486     
- Partials          0     112     +112     
Impacted Files Coverage Δ Complexity Δ
lib/parse.cpp 31.46% <0.00%> (-0.14%) 0.00% <0.00%> (ø%)
lib/parse.h 58.67% <0.00%> (ø) 0.00% <0.00%> (ø%)
lib/coproc.cpp 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
lib/gui_rpc_client.h 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ava/edu/berkeley/boinc/client/MonitorExtensions.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...main/java/edu/berkeley/boinc/rpc/CcStatusParser.kt 94.73% <0.00%> (ø) 27.00% <0.00%> (?%)
...in/java/edu/berkeley/boinc/rpc/StringExtensions.kt 100.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...c/main/java/edu/berkeley/boinc/SettingsFragment.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...a/edu/berkeley/boinc/rpc/TimePreferencesClasses.kt 38.23% <0.00%> (ø) 0.00% <0.00%> (?%)
...edu/berkeley/boinc/ui/eventlog/EventLogActivity.kt 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
... and 94 more

@truboxl
Copy link
Contributor Author

truboxl commented Feb 10, 2021

@truboxl truboxl closed this Mar 8, 2021
@truboxl truboxl deleted the truboxl/android-new-domain branch March 8, 2021 13:46
@truboxl truboxl restored the truboxl/android-new-domain branch March 8, 2021 13:47
@truboxl truboxl reopened this Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the domain name creation process on Android
2 participants