Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/helmchart #40

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

fanff
Copy link

@fanff fanff commented Mar 26, 2024

This pull request introduces Helm charts for both the frontend and backend components of our application, alongside comprehensive documentation covering installation, configuration, and usage. This effort is aimed at streamlining the deployment process on Kubernetes environments, ensuring a more consistent and manageable release workflow.
Changes

Frontend Helm Chart: A new Helm chart for the frontend service, including customizable values for environment-specific configurations.
Backend Helm Chart: Similar to the frontend, the backend service now has its own Helm chart, facilitating independent deployments and scaling.
Unified Documentation: Added a README.md in the helm directory, detailing prerequisites, installation steps, chart customization

@fanff fanff requested a review from drivian as a code owner March 26, 2024 17:49
@drivian drivian requested a review from harticode March 26, 2024 18:05
Copy link
Contributor

@harticode harticode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

your helm charts are great and really helpful,
however, The image building approach will work locally only when the .env file is available.
which will not be the case in a ci cd pipeline.

@@ -15,18 +15,6 @@ WORKDIR /app
COPY --from=deps /app/node_modules ./node_modules
COPY . .

# Declare all build args are env vars for build
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we removed these, we need to skip validation during build time in
frontend/src/env.mjs
try to build it without .env available in build time which will be the case in a ci/cd pipeline.

also with skipping validation, anything that starts with NEXT_PUBLIC, we need to pass it in publicRuntimeConfig instead of envs otherwise won't be picked up during the running time and will be undefined.

my approach was to put the build-time envs that we needed, in
publicRuntimeConfig check : runtime-configuration
we can ignore the hostname and use just /api/v1.
and then if the backend is hosted in a different host, the dev can just put the full address; (HTTP://......./api/v1)...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants